git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 28, 2010, 10:38 UTC
Message-ID
<alpine.DEB.1.00.1001281137550.3380@intel-tinevez-2-302>
In-Reply-To
<63cde7731001280218g29a63094od4f5a8135c6986a4@mail.gmail.com>
Hi,
On Thu, 28 Jan 2010, Michael Lukashov wrote:
Show 18 quoted lines
> > Thanks. Due to the size of the change, I would acknowledge it only if you
> > have a proof that the reduced startup costs are noticable, for example, by
> > running the test suite.
> >
> > What's the deal with bswap? Isn't it an unrelated change? It needs some
> > better justification. It is unobvious because it is not straight-forward
> > "use pointer to function that was looked up instead of function".
> >
> > Will the result not break the MSVC build?
> >
> > -- Hannes
> >
> 
> "git status" calls ntohs function, which was loaded from ws2_32.dll
> I've noticed that bswap.h contains implementation of ntohl htonl functions,
> so I decided to add implementation of ntohs htons functions, which is
> pretty trivial.
> After that call to "git status" doesn't load ws2_32.dll

I am still not convinced of that patch, because the timings are still missing.

Ciao, Dscho

Previous: Michael LukashovNext: Michael Lukashov
Message 4 of 6 in “Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll”
  1. Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dllMichael Lukashov, Jan 28, 2010
  2. Johannes SixtJan 28, 2010
  3. Michael LukashovJan 28, 2010
  4. Johannes SchindelinJan 28, 2010
  5. Michael LukashovJan 28, 2010
  6. Johannes SixtJan 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.