Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll
- From
Michael Lukashov <michael.lukashov@gmail.com>
- Date
- Jan 28, 2010, 10:18 UTC
- Message-ID
- <63cde7731001280218g29a63094od4f5a8135c6986a4@mail.gmail.com>
- In-Reply-To
- <4B61543F.6020904@viscovery.net>
Show 12 quoted lines
> Thanks. Due to the size of the change, I would acknowledge it only if you > have a proof that the reduced startup costs are noticable, for example, by > running the test suite. > > What's the deal with bswap? Isn't it an unrelated change? It needs some > better justification. It is unobvious because it is not straight-forward > "use pointer to function that was looked up instead of function". > > Will the result not break the MSVC build? > > -- Hannes >
"git status" calls ntohs function, which was loaded from ws2_32.dll I've noticed that bswap.h contains implementation of ntohl htonl functions, so I decided to add implementation of ntohs htons functions, which is pretty trivial. After that call to "git status" doesn't load ws2_32.dll