Re: [PATCH v2] Windows: improve performance by avoiding a static dependency on ws2_32.dll and advapi32.dll

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Jan 28, 2010, 09:09 UTC
Message-ID: <4B61543F.6020904@viscovery.net>
In-Reply-To: <1264666525-4956-1-git-send-email-michael.lukashov@gmail.com>

Michael Lukashov schrieb:

Show 9 quoted lines

> ws2_32.dll is used by limited subset of git commands, such as pull,
> push, fetch, send-email, ... By looking up functions that we need
> at runtime, we can avoid the startup costs of this DLL.
> As a result, we can remove static dependency on advapi32.dll too.
> 
> A call to "git status" loaded
> 
> before:  8 DLL
> after:   4 DLL

Thanks. Due to the size of the change, I would acknowledge it only if you have a proof that the reduced startup costs are noticable, for example, by running the test suite.

What's the deal with bswap? Isn't it an unrelated change? It needs some better justification. It is unobvious because it is not straight-forward "use pointer to function that was looked up instead of function".

Will the result not break the MSVC build?

-- Hannes