git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] remote-curl.c: fix rpc_out()

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 23, 2009, 10:39 UTC
Message-ID
<alpine.DEB.1.00.0911231137170.4985@pacific.mpi-cbg.de>
In-Reply-To
<be6fef0d0911230038y13c23e3ek5591ee0dc3eaa47a@mail.gmail.com>
Hi,
On Mon, 23 Nov 2009, Tay Ray Chuan wrote:
Show 7 quoted lines
> On Mon, Nov 23, 2009 at 1:53 PM, Sverre Rabbelier <srabbelier@gmail.com> 
> wrote:
> > Seems like this type of patch would do very well with a test case or 
> > two?
> 
> ah, but to trigger the code involved, a sufficiently large test 
> repository is needed. The git repository would be enough. :)

I guess you meant "not be enough", as an int can hold a pretty large number until it turns negative.

So I think in this case it is more harm- than helpful to have a test case.

For future reference: if you need a repository with special featurs for testing, it is best to generate it in a test script (see the many test cases labeled 'setup' in our test suite for examples).

Ciao, Dscho

Previous: Tay Ray ChuanNext: Tay Ray Chuan
Message 4 of 7 in “remote-curl.c: fix rpc_out()”
  1. 2/2 remote-curl.c: fix rpc_out()Tay Ray Chuan, Nov 23, 2009
  2. Sverre RabbelierNov 23, 2009
  3. Tay Ray ChuanNov 23, 2009
  4. Johannes SchindelinNov 23, 2009
  5. Tay Ray ChuanNov 23, 2009
  6. Shawn O. PearceNov 23, 2009
  7. Tay Ray ChuanNov 24, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.