Re: [PATCH 2/2] remote-curl.c: fix rpc_out()

From: Tay Ray Chuan <rctay89@gmail.com>
Date: Nov 24, 2009, 01:35 UTC
Message-ID: <be6fef0d0911231735g416d028al1821668be295fe6a@mail.gmail.com>
In-Reply-To: <20091123210415.GH11919@spearce.org>

Hi,

On Tue, Nov 24, 2009 at 5:04 AM, Shawn O. Pearce <spearce@spearce.org> wrote:

Show 10 quoted lines

> If I understand the change right, the only thing that really matters
> here is removing the extra ';' in the if (max < avail) condition.
>
> That bug was the only reason why rpc->len < rpc->pos, and is thus
> the only reason why avail would "go negative" (which it can't do
> since its unsigned, it just wrapped around to a massive value).
> [snip]
> Right.  This bug is really bad and should be fixed.  But the message
> above make this some little after-thought and doesn't explain what
> was wrong with this being here.

point noted.

-- 
Cheers,
Ray Chuan