From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mon, 23 Nov 2009 10:39:31 GMT
Subject: Re: [PATCH 2/2] remote-curl.c: fix rpc_out()
Message-ID: <alpine.DEB.1.00.0911231137170.4985@pacific.mpi-cbg.de>
In-Reply-To: <be6fef0d0911230038y13c23e3ek5591ee0dc3eaa47a@mail.gmail.com>

Hi,

On Mon, 23 Nov 2009, Tay Ray Chuan wrote:

> On Mon, Nov 23, 2009 at 1:53 PM, Sverre Rabbelier <srabbelier@gmail.com> 
> wrote:
> > Seems like this type of patch would do very well with a test case or 
> > two?
> 
> ah, but to trigger the code involved, a sufficiently large test 
> repository is needed. The git repository would be enough. :)

I guess you meant "not be enough", as an int can hold a pretty large 
number until it turns negative.

So I think in this case it is more harm- than helpful to have a test case.

For future reference: if you need a repository with special featurs 
for testing, it is best to generate it in a test script (see the many test 
cases labeled 'setup' in our test suite for examples).

Ciao,
Dscho