git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 0/5] RESEND: git notes

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
May 17, 2009, 16:31 UTC
Message-ID
<alpine.DEB.1.00.0905171826200.26154@pacific.mpi-cbg.de>
In-Reply-To
<4A0ED68F.6060200@drmicha.warpmail.net>
Hi,
On Sat, 16 May 2009, git@drmicha.warpmail.net wrote:
Show 15 quoted lines
> Johan Herland venit, vidit, dixit 16.05.2009 03:45:
> 
> > Dscho has asked me to take over the responsibility for the js/notes 
> > patch series.
> > 
> > The following is a re-roll and resend of the patch series currently in 
> > pu, plus my own 2 patches for adding support for "-m" and "-F" to "git 
> > notes edit".
> > 
> > On advice from Dscho, I have squashed the current bugfix and cleanup 
> > patches in js/notes into the first 4 "main" patches. As a result the 
> > original 15 + 2 patch series is now down to 5 (4 + 1) patches.
> > 
> > In sum, these 5 patches produce the exact same result as the original
> > js/notes series (plus my 2 patches).

Actually, I would like this series not to go in as-is, as the most important obstacle for inclusion into 1.6.2 (IIRC) was that performance was pretty lousy.

In the least, it should allow reading fan-out directories, but preferably it would even _write_ fan-out directories.

The only tricky part was how to decide which notes to take if there are ambiguities, but I think a concatenation (or that shallower paths take precedence) are both viable strategies.

> Well, effectively you removed me (and others) from the author list :|

FWIW whenever I squashed other people's patches into mine (and that is not limited to the 'notes' branch), I tried to add proper attribution to the commit message. In Open Source, the currency is merit, so attribution is important.

Ciao, Dscho

Previous: Johan Herland
Message 19 of 19 in “RESEND: git notes”
  1. 0/5 RESEND: git notesJohan Herland, May 16, 2009
  2. 1/5 Introduce commit notesJohan Herland, May 16, 2009
  3. 2/5 Add a script to edit/inspect notesJohan Herland, May 16, 2009
  4. 3/5 Speed up git notes lookupJohan Herland, May 16, 2009
  5. 4/5 Add an expensive test for git-notesJohan Herland, May 16, 2009
  6. 5/5 Teach "-m <msg>" and "-F <file>" to "git notes edit"Johan Herland, May 16, 2009
  7. Junio C HamanoMay 16, 2009
  8. Johan HerlandMay 16, 2009
  9. 0/5 RESEND: git notesJohan Herland, May 16, 2009
  10. Johannes SchindelinMay 20, 2009
  11. Johan HerlandMay 20, 2009
  12. 1/5 Introduce commit notesJohan Herland, May 16, 2009
  13. 2/5 Add a script to edit/inspect notesJohan Herland, May 16, 2009
  14. 3/5 Speed up git notes lookupJohan Herland, May 16, 2009
  15. 4/5 Add an expensive test for git-notesJohan Herland, May 16, 2009
  16. 5/5 Teach "-m <msg>" and "-F <file>" to "git notes edit"Johan Herland, May 16, 2009
  17. git@drmicha.warpmail.netMay 16, 2009
  18. Johan HerlandMay 16, 2009
  19. Johannes SchindelinMay 17, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.