From: Johannes Schindelin Date: Sun, 17 May 2009 16:31:15 GMT Subject: Re: [PATCH 0/5] RESEND: git notes Message-ID: In-Reply-To: <4A0ED68F.6060200@drmicha.warpmail.net> Hi, On Sat, 16 May 2009, git@drmicha.warpmail.net wrote: > Johan Herland venit, vidit, dixit 16.05.2009 03:45: > > > Dscho has asked me to take over the responsibility for the js/notes > > patch series. > > > > The following is a re-roll and resend of the patch series currently in > > pu, plus my own 2 patches for adding support for "-m" and "-F" to "git > > notes edit". > > > > On advice from Dscho, I have squashed the current bugfix and cleanup > > patches in js/notes into the first 4 "main" patches. As a result the > > original 15 + 2 patch series is now down to 5 (4 + 1) patches. > > > > In sum, these 5 patches produce the exact same result as the original > > js/notes series (plus my 2 patches). Actually, I would like this series not to go in as-is, as the most important obstacle for inclusion into 1.6.2 (IIRC) was that performance was pretty lousy. In the least, it should allow reading fan-out directories, but preferably it would even _write_ fan-out directories. The only tricky part was how to decide which notes to take if there are ambiguities, but I think a concatenation (or that shallower paths take precedence) are both viable strategies. > Well, effectively you removed me (and others) from the author list :| FWIW whenever I squashed other people's patches into mine (and that is not limited to the 'notes' branch), I tried to add proper attribution to the commit message. In Open Source, the currency is merit, so attribution is important. Ciao, Dscho