Re: [PATCH] gitk: use themed tk widgets

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Apr 17, 2009, 10:10 UTC
Message-ID: <alpine.DEB.1.00.0904171206290.6675@intel-tinevez-2-302>
In-Reply-To: <873ac8m8jg.fsf@users.sourceforge.net>

Hi,

On Fri, 17 Apr 2009, Pat Thoyts wrote:

Show 9 quoted lines

> 
>   With Tk 8.5+ use the themed widgets to improve the appearence
>   on Windows and MacOSX. On X11 less difference is apparent but
>   users can select alternate themes by setting *TkTheme in the
>   resource database (eg: *TkTheme: clam)
> 
>   With Tk 8.6 there is a built-in font selection dialog and this
>   patch will make use of that when available as on Windows and
>   MacOSX it calls the native font selection dialog.

I had several conflicts applying your patch, and I do not have object a346bd5 here (not even fetching from Paul's repository), but I fixed them all up. (In function setoptions(), you seemed to remove a part asking about the windowingsystem being "aqua", but my gitk did not have that.)

The end result can be marveled at in 4msysgit's 'ttk' branch.

I did not have time to go through your changes, though.

But can I place another wish with you? It all looks nicer now, except the text which is not anti-aliased... Any chance to fix that?

Ciao, Dscho