git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use themed tk widgets

From
Pat Thoyts <patthoyts@users.sourceforge.net>
Date
Apr 17, 2009, 18:46 UTC
Message-ID
<49E8CE80.9040308@users.sourceforge.net>
In-Reply-To
<alpine.DEB.1.00.0904171206290.6675@intel-tinevez-2-302>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Johannes Schindelin wrote:
Show 24 quoted lines
> Hi,
> 
> On Fri, 17 Apr 2009, Pat Thoyts wrote:
> 
>>   With Tk 8.5+ use the themed widgets to improve the appearence
>>   on Windows and MacOSX. On X11 less difference is apparent but
>>   users can select alternate themes by setting *TkTheme in the
>>   resource database (eg: *TkTheme: clam)
>>
>>   With Tk 8.6 there is a built-in font selection dialog and this
>>   patch will make use of that when available as on Windows and
>>   MacOSX it calls the native font selection dialog.
> 
> I had several conflicts applying your patch, and I do not have object 
> a346bd5 here (not even fetching from Paul's repository), but I fixed them 
> all up.  (In function setoptions(), you seemed to remove a part asking 
> about the windowingsystem being "aqua", but my gitk did not have that.)
> 
> The end result can be marveled at in 4msysgit's 'ttk' branch.
> 
> I did not have time to go through your changes, though.
> 
> But can I place another wish with you?  It all looks nicer now, except the 
> text which is not anti-aliased...  Any chance to fix that?

Anti-aliased text is a feature of Tk 8.5 plus the support in your server and the chosen fonts. Not much to be done about that except choose a nice font. On Windows Tahoma and Consolas should look fine.

I suspect the reason you have conflicts is the patch is generated against the gitk repository and not the git repository. There are some commits in gitk that have not been merged to git yet and my patch lives on top of those.

Pat Thoyts
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iQCVAwUBSejOf2B90JXwhOSJAQI5LwQAkyP+975JkafktWYCe3Agd+i8tWrXqf0E NJqB/yF/WCNvqF8sVYzSnUdlxNDGalxE5Ehnoudg3Ca3AYm0LGsIgmNOBFXK+t9w hUKBIYwMfXInHzoJLVqzQ0n7Ql0o6XopgzyT8KW6ec5Vwkgosc3Y7PqX5VqOsCmo eBU+8JkfnfE= =GPY9 -----END PGP SIGNATURE-----

Previous: Johannes SchindelinNext: Paul Mackerras
Message 3 of 6 in “gitk: use themed tk widgets”
  1. gitk: use themed tk widgetsPat Thoyts, Apr 17, 2009
  2. Johannes SchindelinApr 17, 2009
  3. Pat ThoytsApr 17, 2009
  4. Paul MackerrasApr 17, 2009
  5. gitk: restore pane sizes when using ttk widgetsPat Thoyts, Apr 17, 2009
  6. Paul MackerrasApr 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.