git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitk: use themed tk widgets

From
Paul Mackerras <paulus@samba.org>
Date
Apr 17, 2009, 13:01 UTC
Message-ID
<18920.32172.162401.593355@cargo.ozlabs.ibm.com>
In-Reply-To
<873ac8m8jg.fsf@users.sourceforge.net>
Pat Thoyts writes:
>   With Tk 8.5+ use the themed widgets to improve the appearence
>   on Windows and MacOSX. On X11 less difference is apparent but
>   users can select alternate themes by setting *TkTheme in the
>   resource database (eg: *TkTheme: clam)

Looks nice, but the geometry restoration code doesn't seem to work when using the themed widgets. I normally have gitk set so that the top pane is about half the height of the bottom pane, but when I start gitk with this patch both panes always come up about the same height, no matter what sizes they had last time gitk ran.

I notice that the code that restores the height and width of the top pane is now inside if {!$use_ttk}. Is there no way to restore the pane layout with the themed widgets?

Paul.
Previous: Pat ThoytsNext: Pat Thoyts
Message 4 of 6 in “gitk: use themed tk widgets”
  1. gitk: use themed tk widgetsPat Thoyts, Apr 17, 2009
  2. Johannes SchindelinApr 17, 2009
  3. Pat ThoytsApr 17, 2009
  4. Paul MackerrasApr 17, 2009
  5. gitk: restore pane sizes when using ttk widgetsPat Thoyts, Apr 17, 2009
  6. Paul MackerrasApr 30, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.