git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Respect core.autocrlf when preparing temporary files for external diff

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 21, 2009, 23:54 UTC
Message-ID
<alpine.DEB.1.00.0903220053260.10279@pacific.mpi-cbg.de>
In-Reply-To
<7vocvuekjb.fsf@gitster.siamese.dyndns.org>
Hi,
On Sat, 21 Mar 2009, Junio C Hamano wrote:
Show 8 quoted lines
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When preparing temporary files for an external diff, the files should 
> > be handled as if they were worktree files.
> 
> I do not think so.  convert_to_working_tree() aka "smudge" means you 
> would be feeding crap like $Id$ expansion to the external diff, which we 
> chose not to do quite on purpose.

You might have missed me mentioning that we often can do without temporary files, taking the working directory copies right away?

And if you think about it, it makes complete sense.

Ciao, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 4 of 14 in “Respect core.autocrlf when preparing temporary files for external diff”
  1. Respect core.autocrlf when preparing temporary files for external diffJohannes Schindelin, Mar 21, 2009
  2. Michael J GruberMar 21, 2009
  3. Junio C HamanoMar 21, 2009
  4. Johannes SchindelinMar 21, 2009
  5. Junio C HamanoMar 22, 2009
  6. Junio C HamanoMar 22, 2009
  7. Jeff KingMar 22, 2009
  8. Junio C HamanoMar 22, 2009
  9. Jeff KingMar 22, 2009
  10. Sebastian SchuberthMar 22, 2009
  11. Junio C HamanoMar 22, 2009
  12. Sebastian SchuberthMar 22, 2009
  13. Junio C HamanoMar 22, 2009
  14. Junio C HamanoMar 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.