From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 21 Mar 2009 23:54:43 GMT
Subject: Re: [PATCH] Respect core.autocrlf when preparing temporary files for external diff
Message-ID: <alpine.DEB.1.00.0903220053260.10279@pacific.mpi-cbg.de>
In-Reply-To: <7vocvuekjb.fsf@gitster.siamese.dyndns.org>

Hi,

On Sat, 21 Mar 2009, Junio C Hamano wrote:

> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
> > When preparing temporary files for an external diff, the files should 
> > be handled as if they were worktree files.
> 
> I do not think so.  convert_to_working_tree() aka "smudge" means you 
> would be feeding crap like $Id$ expansion to the external diff, which we 
> chose not to do quite on purpose.

You might have missed me mentioning that we often can do without temporary 
files, taking the working directory copies right away?

And if you think about it, it makes complete sense.

Ciao,
Dscho