git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] test-lib: write test results to test-results/<basename>-<pid>

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 16, 2009, 10:18 UTC
Message-ID
<alpine.DEB.1.00.0903161115520.5741@eeepc-johanness>
In-Reply-To
<fabb9a1e0903140616q3770f89axff84755abb1f47c7@mail.gmail.com>
Hi,
On Sat, 14 Mar 2009, Sverre Rabbelier wrote:
Show 10 quoted lines
> On Sat, Mar 14, 2009 at 13:28, SZEDER Gábor <szeder@ira.uka.de> wrote:
> > With my proposed change there would be no need to clean 'test-results'
> > before running the tests, because test-lib.sh would take care of that
> > (not by removing and recreating 'test-results/', but by overwriting
> > (IOW: removing and recreating, but in one step) individual test result
> > files).
> 
> Wouldn't that result in possible stale files being counted in the
> result (e.g., if those tests were not run this time, but they were run
> previously)?

Yes. Stale files would be counted in. The fact that aggregate-results.sh is called when running "make" in t/ is a sure sign for me that you should not muddy waters by making unnecessary changes that break the default usage from time to time.

So I really, really, really, really would like that patch _not_ to be applied.

And I really would like to be able to spend my time on other things than discussing this at more length than necessary.

Ciao, Dscho

Previous: SZEDER GáborNext: SZEDER Gábor
Message 11 of 14 in “test-lib: write test results to test-results/<basename>-<pid>”
  1. test-lib: write test results to test-results/<basename>-<pid>Johannes Schindelin, Mar 13, 2009
  2. Johannes SchindelinMar 13, 2009
  3. SZEDER GáborMar 13, 2009
  4. SZEDER GáborMar 13, 2009
  5. Johannes SchindelinMar 14, 2009
  6. SZEDER GáborMar 14, 2009
  7. Johannes SchindelinMar 14, 2009
  8. SZEDER GáborMar 14, 2009
  9. Sverre RabbelierMar 14, 2009
  10. SZEDER GáborMar 14, 2009
  11. Johannes SchindelinMar 16, 2009
  12. SZEDER GáborMar 16, 2009
  13. Junio C HamanoMar 13, 2009
  14. Junio C HamanoMar 13, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.