Re: [PATCH] test-lib: write test results to test-results/<basename>-<pid>

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 13, 2009, 17:20 UTC
Message-ID: <7viqmdgx0b.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <alpine.DEB.1.00.0903131735110.6288@intel-tinevez-2-302>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 17 quoted lines

> On Fri, 13 Mar 2009, Johannes Schindelin wrote:
>
>> The earlier code meant to attempt to strip everything except the test
>> number, but only stripped the part starting with the last dash.
>> 
>> However, there is no reason why we should not use the whole basename.
>> 
>> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
>> ---
>> 
>> 	Even if this is not strictly necessary after Hannes' test cleanup, 
>> 	it would still be nice.
>
> Just to clarify: it fixes the issue that these two tests share the same 
> file in test-results/: t5521-pull-options.sh  t5521-pull-symlink.sh
>
> As a consequence, one's results overwrite the other one's.

Are you saying that your "fix" will break things if we did not have renames from j6t?

What bug/problem/issue does this patch fix?

I never look into test-results/ subdirectory myself (I'll let the summarizing code do that for me) and the full names never bothered me.

Actually I've always thought it was a very nice touch by you to make sure results will not be mixed up even when we have more than 10 tests in the same category and some tests need to share their numbers, and and your "meant to ... strip everything" above gave me "Huh?"