Re: [PATCH] test-lib: write test results to test-results/<basename>-<pid>

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Mar 14, 2009, 11:53 UTC
Message-ID: <alpine.DEB.1.00.0903141250450.10279@pacific.mpi-cbg.de>
In-Reply-To: <20090313172002.GA16232@neumann>

Hi,

On Fri, 13 Mar 2009, SZEDER Gábor wrote:

Show 27 quoted lines

> diff --git a/t/Makefile b/t/Makefile
> index 0d65ced..2e6e205 100644
> --- a/t/Makefile
> +++ b/t/Makefile
> @@ -14,14 +14,11 @@ SHELL_PATH_SQ = $(subst ','\'',$(SHELL_PATH))
>  T = $(wildcard t[0-9][0-9][0-9][0-9]-*.sh)
>  TSVN = $(wildcard t91[0-9][0-9]-*.sh)
>  
> -all: pre-clean $(T) aggregate-results clean
> +all: $(T) aggregate-results clean
>  
>  $(T):
>  	@echo "*** $@ ***"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)
>  
> -pre-clean:
> -	$(RM) -r test-results
> -
>  clean:
>  	$(RM) -r 'trash directory' test-results
>  
> @@ -33,5 +30,5 @@ full-svn-test:
>  	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=1 LC_ALL=C
>  	$(MAKE) $(TSVN) GIT_SVN_NO_OPTIMIZE_COMMITS=0 LC_ALL=en_US.UTF-8
>  
> -.PHONY: pre-clean $(T) aggregate-results clean
> +.PHONY: $(T) aggregate-results clean
>  .NOTPARALLEL:

This is wrong. If you have failing tests, or if you interrupt the tests, it will never clean the test results, and after Hannes' patch you _will_ have stale files lying around all the time.

I'd rather not have this change.

Ciao, Dscho