git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFD] builtin-revert.c: release index lock when cherry-picking an empty commit

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Mar 7, 2009, 11:15 UTC
Message-ID
<alpine.DEB.1.00.0903071212350.10279@pacific.mpi-cbg.de>
In-Reply-To
<1236418251-16947-1-git-send-email-chris_johnsen@pobox.com>
Hi,
On Sat, 7 Mar 2009, Chris Johnsen wrote:
Show 8 quoted lines
> When a cherry-pick of an empty commit is done, release the lock
> held on the index.
> 
> The fix is the same as was applied to similar code in 4271666046.
> 
> Signed-off-by: Chris Johnsen <chris_johnsen@pobox.com>
> ---
> [...]
Thanks for the detailed explanation, and the patch!

I wonder, though, if the real root of the problem is that there is copied code. IOW I think it would be better to introduce a global function that writes the index to a tree. A quick "git grep commit_locked_index" reveals quite a few code sites...

Thanks, Dscho

Previous: Chris JohnsenNext: Chris Johnsen
Message 2 of 21 in “builtin-revert.c: release index lock when cherry-picking an empty commit”
  1. builtin-revert.c: release index lock when cherry-picking an empty commitChris Johnsen, Mar 7, 2009
  2. Johannes SchindelinMar 7, 2009
  3. Chris JohnsenMar 7, 2009
  4. Johannes SchindelinMar 8, 2009
  5. Junio C HamanoMar 8, 2009
  6. Chris JohnsenMar 8, 2009
  7. Junio C HamanoMar 8, 2009
  8. Jeff KingMar 8, 2009
  9. Jeff KingMar 8, 2009
  10. Junio C HamanoMar 8, 2009
  11. Jeff KingMar 10, 2009
  12. Tomas CarneckyMar 10, 2009
  13. Tomas CarneckyMar 10, 2009
  14. Chris JohnsenMar 10, 2009
  15. Jeff KingMar 11, 2009
  16. Mike RalphsonMar 11, 2009
  17. Mike RalphsonMar 11, 2009
  18. Jeff KingMar 22, 2009
  19. Junio C HamanoMar 22, 2009
  20. Jeff KingMar 22, 2009
  21. Brandon CaseyMar 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.