git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH/RFD] builtin-revert.c: release index lock when cherry-picking an empty commit

From
Junio C Hamano <gitster@pobox.com>
Date
Mar 22, 2009, 21:58 UTC
Message-ID
<7veiwpdxtg.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20090322094139.GA10599@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
> [this is a follow-up on the "eval 'false\n\n'" returns 0 issue on
> FreeBSD]
Thanks for keeping track of this one.
Show 8 quoted lines
> Thanks for looking this up, Mike. It sounds like FreeBSD is probably the
> only problematic one. I confirmed that the problem still exists in
> FreeBSD 7.1, and I've mailed the git ports maintainer off-list to
> make him aware of the issue. So we'll see what happens.
>
> Junio, do you want to put anything in the release notes warning people
> who build from source that this is a potential issue? Do you want
> something in the Makefile detecting that the shell is broken?
A sentence or two in INSTALL will not hurt.

I would not worry too much about the test scripts, but I would worry more about getting phantom bug reports for our shell script Porcelains that get hit by this. Earlier I mentioned bisect is the only heavy user, but the issue is more severe with filter-branch that is designed to eval end user scripts (calls to 'eval "$filter_frotz"' check the exit status and die on failure---with trailing blank lines the failure the filter reports will not get caught).

Previous: Jeff KingNext: Jeff King
Message 19 of 21 in “builtin-revert.c: release index lock when cherry-picking an empty commit”
  1. builtin-revert.c: release index lock when cherry-picking an empty commitChris Johnsen, Mar 7, 2009
  2. Johannes SchindelinMar 7, 2009
  3. Chris JohnsenMar 7, 2009
  4. Johannes SchindelinMar 8, 2009
  5. Junio C HamanoMar 8, 2009
  6. Chris JohnsenMar 8, 2009
  7. Junio C HamanoMar 8, 2009
  8. Jeff KingMar 8, 2009
  9. Jeff KingMar 8, 2009
  10. Junio C HamanoMar 8, 2009
  11. Jeff KingMar 10, 2009
  12. Tomas CarneckyMar 10, 2009
  13. Tomas CarneckyMar 10, 2009
  14. Chris JohnsenMar 10, 2009
  15. Jeff KingMar 11, 2009
  16. Mike RalphsonMar 11, 2009
  17. Mike RalphsonMar 11, 2009
  18. Jeff KingMar 22, 2009
  19. Junio C HamanoMar 22, 2009
  20. Jeff KingMar 22, 2009
  21. Brandon CaseyMar 9, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.