From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Sat, 07 Mar 2009 11:15:58 GMT
Subject: Re: [PATCH/RFD] builtin-revert.c: release index lock when cherry-picking an empty commit
Message-ID: <alpine.DEB.1.00.0903071212350.10279@pacific.mpi-cbg.de>
In-Reply-To: <1236418251-16947-1-git-send-email-chris_johnsen@pobox.com>

Hi,

On Sat, 7 Mar 2009, Chris Johnsen wrote:

> When a cherry-pick of an empty commit is done, release the lock
> held on the index.
> 
> The fix is the same as was applied to similar code in 4271666046.
> 
> Signed-off-by: Chris Johnsen <chris_johnsen@pobox.com>
> ---
> [...]

Thanks for the detailed explanation, and the patch!

I wonder, though, if the real root of the problem is that there is 
copied code.  IOW I think it would be better to introduce a global 
function that writes the index to a tree.  A quick "git grep 
commit_locked_index" reveals quite a few code sites...

Thanks,
Dscho