Re: [PATCH v4] filter-branch -d: Export GIT_DIR earlier
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 18, 2009, 10:25 UTC
- Message-ID
- <alpine.DEB.1.00.0902181125410.6274@intel-tinevez-2-302>
- In-Reply-To
- <20090218083535.GA5466@lars.home.noschinski.de>
Hi,
On Wed, 18 Feb 2009, Lars Noschinski wrote:
Show 15 quoted lines
> The improved error handling catches a bug in filter-branch when using > -d pointing to a path outside any git repository: > > $ git filter-branch -d /tmp/foo master > fatal: Not a git repository (or any of the parent directories): .git > > This error message comes from git for-each-ref in line 224. GIT_DIR is > set correctly by git-sh-setup (to the foo.git repository), but not > exported (yet). > > Signed-off-by: Lars Noschinski <lars@public.noschinski.de> > Acked-by: Johannes Schindelin <Johannes.Schindelin@gmx.de> > --- > > Last iteration :)
Yep, I like it.
Thanks, Dscho