Re: [PATCH v3] filter-branch -d: Export GIT_DIR earlier

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 17, 2009, 23:03 UTC
Message-ID: <alpine.DEB.1.00.0902180002090.10279@pacific.mpi-cbg.de>
In-Reply-To: <20090217180540.GB3564@lars.home.noschinski.de>

Hi,

On Tue, 17 Feb 2009, Lars Noschinski wrote:

Show 18 quoted lines

> The improved error handling catches a bug in filter-branch when using
> -d pointing to a path outside any git repository:
> 
> $ mkdir foo
> $ cd foo
> $ git init
> $ touch bar
> $ git add bar
> $ git commit -m bar
> $ git filter-branch -d /tmp/filter master
> fatal: Not a git repository (or any of the parent directories): .git
> 
> This error message comes from git for-each-ref in line 224. GIT_DIR is
> set correctly by git-sh-setup (to the foo.git repository), but not
> exported (yet).
> 
> Signed-off-by: Lars Noschinski <lars@public.noschinski.de>
> ---

Let me quickly add my ACK before Junio can apply the patch without it. (Even I had the impression that you wanted to trim down the commit message, but it really does not matter to me all that much.)

Ciao, Dscho