Re: [PATCH v2] filter-branch -d: Export GIT_DIR earlier
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 17, 2009, 23:01 UTC
- Message-ID
- <alpine.DEB.1.00.0902172359210.10279@pacific.mpi-cbg.de>
- In-Reply-To
- <20090217175959.GA3564@lars.home.noschinski.de>
Hi,
On Tue, 17 Feb 2009, Lars Noschinski wrote:
> I'll change [make_commit] to test_commit.
Oops, sorry, I actually was not trying to suggest that, but relate a story that I found funny ;-)
> I think as it does not bite us, it would be unnecessary code churn to > remove the remaining usage of make_commit?
Probably. I mean, every cleanup bears a very real possibility of introducing a regression, so it better be worth it. As t7003 seems to work on (case) insensitive filesystems, let's leave it.
Ciao, Dscho