Re: [PATCH] log: make --abbrev-commit's ellipsis configurable

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Feb 13, 2009, 13:20 UTC
Message-ID: <alpine.DEB.1.00.0902131418230.10279@pacific.mpi-cbg.de>
In-Reply-To: <1234529920-9694-1-git-send-email-trast@student.ethz.ch>

Hi,

On Fri, 13 Feb 2009, Thomas Rast wrote:

Show 20 quoted lines

> 'git log --abbrev-commit' adds an ellipsis to all commit names that
> were abbreviated.  This is annoying if you want to cut&paste the sha1
> from the terminal, since selecting by word will pick up '...' too.
> (And this cannot be fixed by making '.' a non-word character; in other
> instances, such as the '123457..abcdef0' from git-fetch, it's part of
> the expression.)
> 
> So we introduce a new variable format.abbrevEllipsis that defaults to
> true (previous behaviour).  If disabled, the formatting routines for
> log/show/whatchanged do not append an ellipsis.
> 
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>[...]
>
>  Documentation/config.txt |    6 ++++++
>  builtin-log.c            |    4 ++++
>  log-tree.c               |   19 ++++++++++++++-----
>  log-tree.h               |    3 +++
>  pretty.c                 |    6 ++----

I am slightly worried that you overshoot here, as log-tree.c has plumbing users, too, no?

How about making this an option, and passing it in rev_opts instead? This option could then be defaulted to in git-log, when the user said --abbrev-commit.

Ciao, Dscho