Re: [PATCH] log: do not print ellipses with --abbrev-commit
- From
Jeff King <peff@peff.net>
- Date
- Feb 13, 2009, 22:24 UTC
- Message-ID
- <20090213222450.GB7424@coredump.intra.peff.net>
- In-Reply-To
- <1234563041-25061-1-git-send-email-trast@student.ethz.ch>
On Fri, Feb 13, 2009 at 11:10:41PM +0100, Thomas Rast wrote:
Show 9 quoted lines
> 'git log --abbrev-commit' added an ellipsis to all commit names that > were abbreviated. This was particularly annoying if you wanted to > cut&paste the sha1 from the terminal, since selecting by word would > pick up '...' too. > > So use find_unique_abbrev() instead of diff_unique_abbrev() in all > log-related commit sha1 printing routines, and also change the > formatting of the 'Merge: parent1 parent2' line output via > pretty_print_commit().
I like this. I have always hated the dots, and even started typing extra --pretty=tformat lines to get rid of them. I always just assumed we didn't want to change the output, but I think Junio's reasoning that scripts cannot be relying on this is sane.
-Peff