Re: [PATCH v2] log: make --abbrev-commit's ellipsis configurable

From: Jakub Narebski <jnareb@gmail.com>
Date: Feb 13, 2009, 16:45 UTC
Message-ID: <8fe92b430902130845r4ebe32eq78f849d66ab899fa@mail.gmail.com>
In-Reply-To: <m363jeux00.fsf@localhost.localdomain>

Johannes Sixt <j.sixt@viscovery.net> writes:

> Thomas Rast schrieb:

Show 14 quoted lines

> > So we introduce a new variable format.abbrevEllipsis that defaults to
> > true (previous behaviour).
>
> How about format.hideAbbrevDots that defaults to false? Then you can write
> in the config file:
>
>     [format]
>          hideAbbrevDots
>
> (note: without '= true').
>
> Even though I usually detest double negations (and I would count
> hideAbbrevDots=false as one), the ability to set the non-default value of
> a Boolean variable in this way trumps my taste.

By the way, should it be in [format] section? I thought that format.* variables are about git-format-patch... Wouldn't it be better to put it in [log] section?

On the other hand we have already format.pretty (but log.date and log.showroot). Nice consistency ;-(

-- Jakub Narebski Poland ShadeHawk on #git