Re: [PATCH] config: Add new option to open an editor.
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 4, 2009, 15:20 UTC
- Message-ID
- <alpine.DEB.1.00.0902041619370.22763@intel-tinevez-2-302>
- In-Reply-To
- <94a0d4530902040703u53a9082fsfa7203b6203bd118@mail.gmail.com>
Hi,
On Wed, 4 Feb 2009, Felipe Contreras wrote:
Show 29 quoted lines
> On Wed, Feb 4, 2009 at 4:53 PM, Jeff King <peff@peff.net> wrote:
> > On Wed, Feb 04, 2009 at 12:40:26AM +0200, Felipe Contreras wrote:
> >
> >> + } else if (!strcmp(argv[1], "--edit") || !strcmp(argv[1], "-e")) {
> >> + char *config_filename;
> >> + if (config_exclusive_filename)
> >> + config_filename = xstrdup(config_exclusive_filename);
> >> + else
> >> + config_filename = git_pathdup("config");
> >> + launch_editor(config_filename, NULL, NULL);
> >> + free(config_filename);
> >> + return 0;
> >> } else
> >
> > With this patch, won't I get different behavior from:
> >
> > git config -e --global
> >
> > versus
> >
> > git config --global -e
>
> Just like you get different behavior from:
>
> git config -l --global
>
> and
>
> git config --global -l... which will be fixed once you parseopt'ified builtin-config, right?
:-)
Ciao, Dscho