Re: [PATCH] config: Add new option to open an editor.
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Feb 4, 2009, 15:42 UTC
- Message-ID
- <94a0d4530902040742o4f2f0b63g44d605e5b28d9b15@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0902041619370.22763@intel-tinevez-2-302>
On Wed, Feb 4, 2009 at 5:20 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 35 quoted lines
> Hi,
>
> On Wed, 4 Feb 2009, Felipe Contreras wrote:
>
>> On Wed, Feb 4, 2009 at 4:53 PM, Jeff King <peff@peff.net> wrote:
>> > On Wed, Feb 04, 2009 at 12:40:26AM +0200, Felipe Contreras wrote:
>> >
>> >> + } else if (!strcmp(argv[1], "--edit") || !strcmp(argv[1], "-e")) {
>> >> + char *config_filename;
>> >> + if (config_exclusive_filename)
>> >> + config_filename = xstrdup(config_exclusive_filename);
>> >> + else
>> >> + config_filename = git_pathdup("config");
>> >> + launch_editor(config_filename, NULL, NULL);
>> >> + free(config_filename);
>> >> + return 0;
>> >> } else
>> >
>> > With this patch, won't I get different behavior from:
>> >
>> > git config -e --global
>> >
>> > versus
>> >
>> > git config --global -e
>>
>> Just like you get different behavior from:
>>
>> git config -l --global
>>
>> and
>>
>> git config --global -l
>
> ... which will be fixed once you parseopt'ified builtin-config, right?I'm going to cleanup the big string, I still haven't looked at parseopt, if it's not too complicated I'll do it.
-- Felipe Contreras