Re: [PATCH v3] config: Add new option to open an editor.
- From
Felipe Contreras <felipe.contreras@gmail.com>
- Date
- Feb 7, 2009, 21:15 UTC
- Message-ID
- <94a0d4530902071315o78b2db58n481fbc6e956b5b64@mail.gmail.com>
- In-Reply-To
- <alpine.DEB.1.00.0902072214410.10279@pacific.mpi-cbg.de>
On Sat, Feb 7, 2009 at 11:14 PM, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
Show 29 quoted lines
> Hi, > > On Sat, 7 Feb 2009, Felipe Contreras wrote: > >> On Thu, Feb 5, 2009 at 1:49 AM, Johannes Schindelin >> <Johannes.Schindelin@gmx.de> wrote: >> > Hi, >> > >> > On Thu, 5 Feb 2009, Johannes Schindelin wrote: >> > >> >> On Wed, 4 Feb 2009, Junio C Hamano wrote: >> >> >> >> > Felipe Contreras <felipe.contreras@gmail.com> writes: >> >> > >> >> > > The idea was originated by discussion about usability of manually >> >> > > editing the config file in 'special needs' systems such as Windows. Now >> >> > > the user can forget a bit about where the config files actually are. >> >> > >> >> > Does this honor core.editor setting in existing configuration files? >> >> >> >> It should, as it uses launch_editor(). >> > >> > Oh, I see that launch_editor() does not do its own git_config() parsing. >> > Dunno if it should... >> >> I think it should, how expensive would it be to call >> git_config(git_default_config, NULL) when it has been loaded already? > > We would not need the complete git_default_config(), would we?
Nope, just core.editor. But I don't know how to load only that.
-- Felipe Contreras