Re: [PATCH] builtin-remote: make rm operation safer in mirrored repository
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Feb 3, 2009, 14:53 UTC
- Message-ID
- <alpine.DEB.1.00.0902031553310.6573@intel-tinevez-2-302>
- In-Reply-To
- <76718490902030638y36299191i1fcc2ab8646b9593@mail.gmail.com>
Hi,
On Tue, 3 Feb 2009, Jay Soffian wrote:
Show 21 quoted lines
> On Tue, Feb 3, 2009 at 2:54 AM, Junio C Hamano <gitster@pobox.com> wrote: > > Jeff King <peff@peff.net> writes: > >> However, I have one small nit. The output produces long lines with a lot > >> of repeated text (assuming you have multiple matched branches, which is > >> likely if you have a mirrored setup). So maybe it would be nicer to have > >> something like: > >> > >> warning: non-remote branches were not removed; you can delete them with: > >> git branch -d master > >> git branch -d next > >> git branch -d topic > >> > >> which is a little more obvious (to me, anyway), and allows you to cut > >> and paste if you really did want to delete them. > > > > Thanks for a review, and I actually shared that exact nit when I first > > read the patch. It would be a very good change to collect them in a list > > and show a single warning at the end (I do not have particular preference > > about the cut & paste-ability either way myself). > > This is a tough crowd. I'll see what I can do.
We polish it until it shines! :-)
Thank you for you efforts, Dscho