Re: [PATCH] builtin-remote: make rm operation safer in mirrored repository

From: Jeff King <peff@peff.net>
Date: Feb 3, 2009, 07:24 UTC
Message-ID: <20090203072418.GD21367@sigill.intra.peff.net>
In-Reply-To: <1233600014-82346-1-git-send-email-jaysoffian@gmail.com>

On Mon, Feb 02, 2009 at 01:40:14PM -0500, Jay Soffian wrote:

> This version adds a test case. I also noticed that the check I'd added to
> add_branch_for_removal() was generating spurious warnings because I'd added it
> in the wrong place; this version moves the check below the
> remote_find_tracking() checks.

This version looks fine to me, and I would be OK with it being applied.

However, I have one small nit. The output produces long lines with a lot of repeated text (assuming you have multiple matched branches, which is likely if you have a mirrored setup). So maybe it would be nicer to have something like:

  warning: non-remote branches were not removed; you can delete them with:
          git branch -d master
          git branch -d next
          git branch -d topic

which is a little more obvious (to me, anyway), and allows you to cut and paste if you really did want to delete them.

But this should be a pretty seldom seen message, so it might not matter much. I just thought I would throw it out there.

-Peff