Re: [RFC/PATCH v3 3/3] archive.c: add basic support for submodules

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jan 23, 2009, 19:57 UTC
Message-ID: <alpine.DEB.1.00.0901232054360.21467@intel-tinevez-2-302>
In-Reply-To: <8c5c35580901231040i380c6458x1a6103cd6f55c479@mail.gmail.com>

Hi,

On Fri, 23 Jan 2009, Lars Hjemli wrote:

Show 17 quoted lines

> On Fri, Jan 23, 2009 at 00:44, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > On Thu, 22 Jan 2009, Lars Hjemli wrote:
> >
> >> The new --submodules option is used to trigger inclusion of checked out
> >> submodules in the archive.
> >>
> >> The implementation currently does not verify that the submodule has 
> >> been registered as 'interesting' in .git/config, neither does it 
> >> resolve the currently checked out submodule HEAD but instead uses the 
> >> commit SHA1 recorded in the gitlink entry to identify the submodule 
> >> root tree.
> >
> > Please understand that I skipped the rest of the patch.
> 
> That's too bad, I hoped on some feedback from you on the part of the 
> commit message which you didn't quote:

Well, you ignored my comments, so what do you expect me to do?  Be happy?

There are two issues there:

- presence of a specific commit object being present in the repository 
  does not necessarily mean that it is reachable by any ref, and therefore 
  can mean that the tree/blob objects are not reachable, because it could 
  be an interrupted fetch; in all of Git, we try to assume that only 
  reachable objects are valid objects.

- presence of a specific commit in the supermodule is a _lousy_ indicator 
  that the user wants to include that submodule in the archive.

Until both issues are addresse, I will not dance a little song and be merry over this issue.

Ciao, Dscho