git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH v3 3/3] archive.c: add basic support for submodules

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 23, 2009, 19:23 UTC
Message-ID
<7vzlhhu8qo.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<8c5c35580901231040i380c6458x1a6103cd6f55c479@mail.gmail.com>
Lars Hjemli <hjemli@gmail.com> writes:
>>> The plan is to fix these limitations by extending --submodules to allow
>>> certain flags/options:
>>> a|c|r     include any|checked out|registered submodules
>>> H         resolve submodule HEAD to decide which tree to include

What do you mean by "decide"? If HEAD exists (iow, the submodule is checked out), the tree of the commit recorded in the superproject's gitlink entry is included in the result?

As I already said before, I doubt it makes much sense in the context of the current git-archive to base the choise on checkout status.

Unless you are extending git-archive and giving it an ability to write out the superproject index or the work tree as an archive, that is.

Just like git-grep lets you grep in the work tree files (limited to paths that appear in the index), or grep in the contents registered to the index when run with --cached, git-archive could make an archive out of your work tree files or your index contents. Such an extension to git-archive may be quite useful with or without submodules.

In such mode of operation, because you are dealing with the work tree when run without --cached, it would make sense to say "Ah, the superproject index wants v1.0 of the submodule, but the work tree has v2.0 of it checked out, and we are writing out the work tree, so let's include v2.0 instead", and as a side effect of deciding which commit's tree to include from each submodule, it naturally makes sense to exclude submodules that are not checked out.

But otherwise I am not so sure what the point of H option would be.
Previous: Lars HjemliNext: Lars Hjemli
Message 7 of 19 in “Add support for `git archive --submodules`”
  1. 0/3 Add support for `git archive --submodules`Lars Hjemli, Jan 22, 2009
  2. 1/3 tree.c: teach read_tree_recursive how to traverse gitlink entriesLars Hjemli, Jan 22, 2009
  3. 2/3 sha1_file: prepare for adding alternates on demandLars Hjemli, Jan 22, 2009
  4. 3/3 archive.c: add basic support for submodulesLars Hjemli, Jan 22, 2009
  5. Johannes SchindelinJan 22, 2009
  6. Lars HjemliJan 23, 2009
  7. Junio C HamanoJan 23, 2009
  8. Lars HjemliJan 23, 2009
  9. Junio C HamanoJan 23, 2009
  10. Lars HjemliJan 23, 2009
  11. Johannes SchindelinJan 23, 2009
  12. Lars HjemliJan 24, 2009
  13. Johannes SchindelinJan 24, 2009
  14. Lars HjemliJan 24, 2009
  15. Johannes SchindelinJan 24, 2009
  16. Lars HjemliJan 24, 2009
  17. Johannes SchindelinJan 22, 2009
  18. Lars HjemliJan 23, 2009
  19. Johannes SchindelinJan 23, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.