Re: [RFC/PATCH v3 2/3] sha1_file: prepare for adding alternates on demand
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Jan 23, 2009, 19:54 UTC
- Message-ID
- <alpine.DEB.1.00.0901232054090.21467@intel-tinevez-2-302>
- In-Reply-To
- <8c5c35580901231035j31484249nf96e0e659b119a2b@mail.gmail.com>
Hi,
On Fri, 23 Jan 2009, Lars Hjemli wrote:
Show 20 quoted lines
> On Fri, Jan 23, 2009 at 00:43, Johannes Schindelin
> <Johannes.Schindelin@gmx.de> wrote:
> > On Thu, 22 Jan 2009, Lars Hjemli wrote:
> >> + if (!quiet)
> >> + error("object directory %s does not exist; "
> >> + "check .git/objects/info/alternates.",
> >> + ent->base);
> >
> > FWIW my concern is not at all addressed. A future user of add_alt_odb()
> > (and possibly your users in rare cases, too) can trigger the error that
> > suggests looking into the alternates. Leaving the human user puzzled.
>
> Is it the phrasing of the error message that concerns you (when
> invoked from add_alt_odb())?
>
> If so, would something like this be ok/better?
>
> >> + if (!quiet)
> >> + error("Alternate object directory %s does not exist ",
> >> + ent->base);That would almost certainly be better.
Ciao, Dscho