git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Add --contains flag to git tag

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Jan 21, 2009, 08:21 UTC
Message-ID
<alpine.DEB.1.00.0901210919030.7929@racer>
In-Reply-To
<25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com>
Hi,
On Tue, 20 Jan 2009, Jake Goulding wrote:
> I actually have 1 commit for the code change, one for documentation, and 
> one for the test case. Should I squash all these together?

In general, if the patches are not very large and logically belong together, it is a matter of taste if you squash together documentation and code changes. Tests, however, belong with the code.

> Also, my test case is in a separate file (t7704-tag-contains.sh) as that 
> is how I read t/README. Was this incorrect?

Again, the size matters. If it is a single test case, it is not worth a whole new file, especially when something like t7004-tag.sh already exists, whose name just asks for your test case to go in there.

Ciao, Dscho

Previous: Jake GouldingNext: Junio C Hamano
Message 4 of 5 in “Re: [PATCH] Add --contains flag to git tag”
  1. Jake GouldingJan 21, 2009
  2. Miklos VajnaJan 21, 2009
  3. Jake GouldingJan 21, 2009
  4. Johannes SchindelinJan 21, 2009
  5. Junio C HamanoJan 22, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.