From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Wed, 21 Jan 2009 08:21:30 GMT
Subject: Re: [PATCH] Add --contains flag to git tag
Message-ID: <alpine.DEB.1.00.0901210919030.7929@racer>
In-Reply-To: <25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com>

Hi,

On Tue, 20 Jan 2009, Jake Goulding wrote:

> I actually have 1 commit for the code change, one for documentation, and 
> one for the test case. Should I squash all these together?

In general, if the patches are not very large and logically belong 
together, it is a matter of taste if you squash together documentation and 
code changes.  Tests, however, belong with the code.

> Also, my test case is in a separate file (t7704-tag-contains.sh) as that 
> is how I read t/README. Was this incorrect?

Again, the size matters.  If it is a single test case, it is not worth a 
whole new file, especially when something like t7004-tag.sh already 
exists, whose name just asks for your test case to go in there.

Ciao,
Dscho