Re: [PATCH] Add --contains flag to git tag
- From
Jake Goulding <goulding@vivisimo.com>
- Date
- Jan 21, 2009, 03:54 UTC
- Message-ID
- <25058429.247441232510076471.JavaMail.root@scalix.vivisimo.com>
- In-Reply-To
- <20090121032058.GG21473@genesis.frugalware.org>
That is actually in a subsequent commit (in my unmarked patch sequence).
I actually have 1 commit for the code change, one for documentation, and one for the test case. Should I squash all these together?
Also, my test case is in a separate file (t7704-tag-contains.sh) as that is how I read t/README. Was this incorrect?
Thanks!
-Jake
----- Original Message ----- From: "Miklos Vajna" <vmiklos@frugalware.org> To: "Jake Goulding" <goulding@vivisimo.com> Cc: git@vger.kernel.org Sent: Tuesday, January 20, 2009 10:20:58 PM GMT -05:00 US/Canada Eastern Subject: Re: [PATCH] Add --contains flag to git tag
On Tue, Jan 20, 2009 at 08:37:09PM -0500, Jake Goulding <goulding@vivisimo.com> wrote:
> Please let me know what else I have inevitably messed up, and I shall > endeavor to fix and resubmit.
Please document your improvements in Documentation/git-tag.txt and don't forget to add a testcase to t7004-tag.sh.