Re: [PATCH] gitk: force focus to main window
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Dec 18, 2008, 03:14 UTC
- Message-ID
- <alpine.DEB.1.00.0812180413240.14632@racer>
- In-Reply-To
- <18761.29020.237388.687560@cargo.ozlabs.ibm.com>
Hi,
On Thu, 18 Dec 2008, Paul Mackerras wrote:
Show 9 quoted lines
> Johannes Sixt writes: > > > On msysGit, the focus is first on the (Tk) console. This console is > > then hidden, but keeps the focus. Work around that by forcing the > > focus onto the gitk window. > > Hmmm, I don't like doing focus -force unconditionally on all platforms. > I hate it when applications decide they know best and override what the > window manager decides.
>From my previous experience with my patches to gitk, I did not expect
otherwise. That is why I did not even bother with this one.
> At least put a if {[tk windowingsystem] eq "win32"} in there. (msysGit
> is a windows thing, isn't it?)Yeah, because on other platforms, when you start gitk, you don't want it to take focus. Yeah, right.
Ciao, Dscho