patchgitk: force focus to main window

From: Johannes Schindelin <johannes.schindelin@gmx.de>

On msysGit, the focus is first on the (Tk) console. This console is then hidden, but keeps the focus. Work around that by forcing the focus onto the gitk window.

This fixes issue 14.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
 gitk-git/gitk |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

Johannes Sixt writes:

Hmmm, I don't like doing focus -force unconditionally on all platforms. I hate it when applications decide they know best and override what the window manager decides.

At least put a if {[tk windowingsystem] eq "win32"} in there. (msysGit is a windows thing, isn't it?)

Paul.

Hi,

On Thu, 18 Dec 2008, Paul Mackerras wrote:

otherwise.  That is why I did not even bother with this one.

Yeah, because on other platforms, when you start gitk, you don't want it to take focus. Yeah, right.

Ciao, Dscho

On Thu, Dec 18, 2008 at 04:14:25AM +0100, Johannes Schindelin wrote:

That is _exactly_ what I want on my platform: no window should steal the focus when I am in the middle of typing in some other window. And to that end, my window manager does not shift the focus until I tell it to do so.

So yes, this patch _does_ break at least my setup. But more importantly, it is an application making a decision about focus policy that should be made by the window manager. I understand that the window manager in Windows sucks, and that this is a workaround that makes things better there. But please don't inflict this braindeadedness on the rest of us.

-Peff

Johannes Schindelin writes:

No - on other platforms I have a window manager that gives focus to new applications automatically. Or, if I don't want new applications to grab the focus, I tell the window manager that that's what the policy should be. Either way the application shouldn't forcibly and unilaterally grab the focus.

I'm prepared (predisposed, even :-) to believe that windows sucks, so I'll take the patch if it only affects windows.

Paul.

From: Johannes Sixt <j6t@kdbg.org>

On msysGit, the focus is first on the (Tk) console. This console is then hidden, but keeps the focus. Work around that by forcing the focus onto the gitk window.

This fixes msysGit issue 14. Diagnosed and originally fixed by Johannes Schindelin.

Signed-off-by: Johannes Sixt <j6t@kdbg.org>
---
Paul Mackerras schrieb:

I did that.

-- Hannes

 gitk |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)