Re: [PATCH] gitk: force focus to main window

From: Jeff King <peff@peff.net>
Date: Dec 18, 2008, 03:23 UTC
Message-ID: <20081218032358.GB20749@coredump.intra.peff.net>
In-Reply-To: <alpine.DEB.1.00.0812180413240.14632@racer>

On Thu, Dec 18, 2008 at 04:14:25AM +0100, Johannes Schindelin wrote:

Show 5 quoted lines

> > At least put a if {[tk windowingsystem] eq "win32"} in there. (msysGit 
> > is a windows thing, isn't it?)
> 
> Yeah, because on other platforms, when you start gitk, you don't want it 
> to take focus.  Yeah, right.

That is _exactly_ what I want on my platform: no window should steal the focus when I am in the middle of typing in some other window. And to that end, my window manager does not shift the focus until I tell it to do so.

So yes, this patch _does_ break at least my setup. But more importantly, it is an application making a decision about focus policy that should be made by the window manager. I understand that the window manager in Windows sucks, and that this is a workaround that makes things better there. But please don't inflict this braindeadedness on the rest of us.

-Peff