git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Dec 5, 2008, 12:21 UTC
Message-ID
<alpine.DEB.1.00.0812051320170.7062@intel-tinevez-2-302>
In-Reply-To
<1228443780-3386-3-git-send-email-gitster@pobox.com>
Hi,
On Thu, 4 Dec 2008, Junio C Hamano wrote:
> -	echo " $ws" >"$dotest/whitespace"
> +	echo " $git_apply_opt" >"$dotest/apply_opt_extra"
>From the other scripts, it appears we have sort of a convention to use

dashes instead of underscores for file names (see e.g. $dotest/patch-merge-tmp-dir).

Other than that, the whole series looks good to me.

Thanks for the work, especially the tests, Dscho

Previous: Junio C HamanoNext: Junio C Hamano
Message 6 of 7 in “Fix longstanding "git am" bug”
  1. 0/4 Fix longstanding "git am" bugJunio C Hamano, Dec 5, 2008
  2. 1/4 git-am --whitespace: do not lose the command line optionJunio C Hamano, Dec 5, 2008
  3. 2/4 git-am: propagate -C<n>, -p<n> options as wellJunio C Hamano, Dec 5, 2008
  4. 3/4 git-am: propagate --3way options as wellJunio C Hamano, Dec 5, 2008
  5. 4/4 Test that git-am does not lose -C/-p/--whitespace optionsJunio C Hamano, Dec 5, 2008
  6. Johannes SchindelinDec 5, 2008
  7. Junio C HamanoDec 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.