git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well

From
Junio C Hamano <gitster@pobox.com>
Date
Dec 5, 2008, 19:18 UTC
Message-ID
<7v7i6e1ld8.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<alpine.DEB.1.00.0812051320170.7062@intel-tinevez-2-302>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 8 quoted lines
> On Thu, 4 Dec 2008, Junio C Hamano wrote:
>
>> -	echo " $ws" >"$dotest/whitespace"
>> +	echo " $git_apply_opt" >"$dotest/apply_opt_extra"
>
>>From the other scripts, it appears we have sort of a convention to use 
> dashes instead of underscores for file names (see e.g. 
> $dotest/patch-merge-tmp-dir).
You are right.  And there is no reason to call it "extra" either.
 git-am.sh |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git c/git-am.sh w/git-am.sh
index 13c02d6..4b157fe 100755
--- c/git-am.sh
+++ w/git-am.sh
@@ -250,7 +250,7 @@ else
 	# -s, -u, -k, --whitespace, -3, -C and -p flags are kept
 	# for the resuming session after a patch failure.
 	# -i can and must be given when resuming.
-	echo " $git_apply_opt" >"$dotest/apply_opt_extra"
+	echo " $git_apply_opt" >"$dotest/apply-opt"
 	echo "$threeway" >"$dotest/threeway"
 	echo "$sign" >"$dotest/sign"
 	echo "$utf8" >"$dotest/utf8"
@@ -288,7 +288,7 @@ if test "$(cat "$dotest/threeway")" = t
 then
 	threeway=t
 fi
-git_apply_opt=$(cat "$dotest/apply_opt_extra")
+git_apply_opt=$(cat "$dotest/apply-opt")
 if test "$(cat "$dotest/sign")" = t
 then
 	SIGNOFF=`git var GIT_COMMITTER_IDENT | sed -e '
Previous: Johannes Schindelin
Message 7 of 7 in “Fix longstanding "git am" bug”
  1. 0/4 Fix longstanding "git am" bugJunio C Hamano, Dec 5, 2008
  2. 1/4 git-am --whitespace: do not lose the command line optionJunio C Hamano, Dec 5, 2008
  3. 2/4 git-am: propagate -C<n>, -p<n> options as wellJunio C Hamano, Dec 5, 2008
  4. 3/4 git-am: propagate --3way options as wellJunio C Hamano, Dec 5, 2008
  5. 4/4 Test that git-am does not lose -C/-p/--whitespace optionsJunio C Hamano, Dec 5, 2008
  6. Johannes SchindelinDec 5, 2008
  7. Junio C HamanoDec 5, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.