From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Fri, 05 Dec 2008 12:21:43 GMT
Subject: Re: [PATCH 2/4] git-am: propagate -C<n>, -p<n> options as well
Message-ID: <alpine.DEB.1.00.0812051320170.7062@intel-tinevez-2-302>
In-Reply-To: <1228443780-3386-3-git-send-email-gitster@pobox.com>

Hi,

On Thu, 4 Dec 2008, Junio C Hamano wrote:

> -	echo " $ws" >"$dotest/whitespace"
> +	echo " $git_apply_opt" >"$dotest/apply_opt_extra"

>From the other scripts, it appears we have sort of a convention to use 
dashes instead of underscores for file names (see e.g. 
$dotest/patch-merge-tmp-dir).

Other than that, the whole series looks good to me.

Thanks for the work, especially the tests,
Dscho