Re: [RFC/PATCH] bisect: teach "skip" to accept special arguments like "A..B"
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 24, 2008, 10:35 UTC
- Message-ID
- <alpine.DEB.1.00.0811241134540.30769@pacific.mpi-cbg.de>
- In-Reply-To
- <492A5346.1040405@viscovery.net>
Hi,
On Mon, 24 Nov 2008, Johannes Sixt wrote:
Show 29 quoted lines
> Johannes Schindelin schrieb: > > On Sun, 23 Nov 2008, Christian Couder wrote: > >> Dscho wrote: > >> > Would it not be more intuitive to have support for > >> > > >> > git bisect skip A..B > >> > > >> > ? > >> > >> Here is a patch to do that. I am not sure it's worth it > >> because this is a special case in many ways. > > > > Why not have something like > > > > skip) > > for arg in $(git rev-list "$@") > > do > > bisect_state skip $arg > > done > > Because if you say > > $ git bisect skip > > this would be incorrectly calling rev-list; but more importantly, if you say > > $ git bisect skip A > > then this would skip A *and all its ancestors*. Not quite what you intended.
Good point indeed.
Thanks, Dscho