git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [RFC/PATCH] bisect: teach "skip" to accept special arguments like "A..B"

From
Johannes Schindelin <johannes.schindelin@gmx.de>
Date
Nov 24, 2008, 00:28 UTC
Message-ID
<alpine.DEB.1.00.0811240126430.30769@pacific.mpi-cbg.de>
In-Reply-To
<20081123220249.2e7f30a5.chriscool@tuxfamily.org>
Hi,
On Sun, 23 Nov 2008, Christian Couder wrote:
Show 17 quoted lines
> The current "git bisect skip" syntax is "git bisect skip [<rev>...]"
> so it's already possible to skip a range of revisions using
> something like:
> 
> $ git bisect skip $(git rev-list A..B)
> 
> where A and B are the bounds of the range we want to skip.
> 
> This patch teaches "git bisect skip" to accept:
> 
> $ git bisect skip A..B
> 
> as an abbreviation for the former command.
> 
> This is done by checking each argument to see if it contains two
> dots one after the other ('..'), and by expending it using
> "git rev-list" if that is the case.
s/expend/expand/
Show 19 quoted lines
> Note that this patch will not make "git bisect skip" accept all
> that "git rev-list" accepts, as things like "^A B" for exemple
> will not work. But things like "A B..C D E F.. ..G H...I" should
> work as expected.
> 
> Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
> ---
>  git-bisect.sh |   19 ++++++++++++++++++-
>  1 files changed, 18 insertions(+), 1 deletions(-)
> 
> 	Dscho wrote:
> 	> Would it not be more intuitive to have support for
> 	>
>         > git bisect skip A..B
> 	>
> 	> ?
> 
> 	Here is a patch to do that. I am not sure it's worth it
> 	because this is a special case in many ways.
Why not have something like
	skip)
		for arg in $(git rev-list "$@")
		do
			bisect_state skip $arg
		done
?

Ciao, Dscho

Previous: Christian CouderNext: Johannes Sixt
Message 2 of 5 in “bisect: teach "skip" to accept special arguments like "A..B"”
  1. bisect: teach "skip" to accept special arguments like "A..B"Christian Couder, Nov 23, 2008
  2. Johannes SchindelinNov 24, 2008
  3. Johannes SixtNov 24, 2008
  4. Johannes SchindelinNov 24, 2008
  5. Junio C HamanoNov 26, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.