Re: [RFC/PATCH] bisect: teach "skip" to accept special arguments like "A..B"

From: Johannes Sixt <j.sixt@viscovery.net>
Date: Nov 24, 2008, 07:09 UTC
Message-ID: <492A5346.1040405@viscovery.net>
In-Reply-To: <alpine.DEB.1.00.0811240126430.30769@pacific.mpi-cbg.de>

Johannes Schindelin schrieb:

Show 18 quoted lines

> On Sun, 23 Nov 2008, Christian Couder wrote:
>> 	Dscho wrote:
>> 	> Would it not be more intuitive to have support for
>> 	>
>>         > git bisect skip A..B
>> 	>
>> 	> ?
>>
>> 	Here is a patch to do that. I am not sure it's worth it
>> 	because this is a special case in many ways.
> 
> Why not have something like
> 
> 	skip)
> 		for arg in $(git rev-list "$@")
> 		do
> 			bisect_state skip $arg
> 		done

Because if you say

	$ git bisect skip

this would be incorrectly calling rev-list; but more importantly, if you say

	$ git bisect skip A

then this would skip A *and all its ancestors*. Not quite what you intended.

-- Hannes