Re: [RFC PATCH 0/4] deny push to current branch of non-bare repo
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Nov 8, 2008, 15:12 UTC
- Message-ID
- <alpine.DEB.1.00.0811081609530.30769@pacific.mpi-cbg.de>
- In-Reply-To
- <20081108142756.GC17100@coredump.intra.peff.net>
Hi,
On Sat, 8 Nov 2008, Jeff King wrote:
Show 15 quoted lines
> On Fri, Nov 07, 2008 at 03:16:53PM -0800, Junio C Hamano wrote: > > > > The FAQ even says "don't do this until you know what you are doing." > > > So the safety valve is configurable, so that those who know what > > > they are doing can switch it off. > > > > "We are breaking your existing working setup but you can add a new > > configuration to unbreak it" should not be done lightly. I think as > > the end result it is a reasonable thing to aim for for this particular > > feature, but we do need a transition plan patch in between that > > introduces a step that warns but not forbids. We can ship 1.6.1 with > > it and then switch the default to forbid in 1.6.3, for example. > > Yeah, I was kind of hoping we could assume that anybody relying on this > behavior was somewhat insane, and wouldn't be too upset when it broke.
I think I have a repository with "git read-tree -u -m HEAD" as update hook for that kind of behavior.
But I will not be the person responsible to keep that behavior, if I am the only one relying on it.
I very much like the approach of defaulting to "warn" for quite some time (but setting the variable to "refuse" in git-init) and then adapt the default after some time.
Ciao, Dscho