Re: [RFC PATCH 0/4] deny push to current branch of non-bare repo

From: Jeff King <peff@peff.net>
Date: Nov 8, 2008, 14:27 UTC
Message-ID: <20081108142756.GC17100@coredump.intra.peff.net>
In-Reply-To: <7v3ai3f7oa.fsf@gitster.siamese.dyndns.org>

On Fri, Nov 07, 2008 at 03:16:53PM -0800, Junio C Hamano wrote:

Show 10 quoted lines

> > The FAQ even says "don't do this until you know what you are doing." So
> > the safety valve is configurable, so that those who know what they are
> > doing can switch it off.
> 
> "We are breaking your existing working setup but you can add a new
> configuration to unbreak it" should not be done lightly.  I think as the
> end result it is a reasonable thing to aim for for this particular
> feature, but we do need a transition plan patch in between that introduces
> a step that warns but not forbids.  We can ship 1.6.1 with it and then
> switch the default to forbid in 1.6.3, for example.

Yeah, I was kind of hoping we could assume that anybody relying on this behavior was somewhat insane, and wouldn't be too upset when it broke. But you're probably right that we should be more conservative. I'll rework it with a "yes/no/warn" option for the config, and we can set it to "warn" (and those who really do want it can shut off the warning with "no"). Or we can even start with just leaving it on "no", but I think the deprecation period should begin when we switch it to "warn".

Show 8 quoted lines

> > Patch 4/4 is the interesting one. 1/4 is a cleanup I saw while fixing
> > tests. 2/4 is a cleanup to prepare for 3/4. And 3/4 fixes a bunch of
> > tests which were inadvertently doing such a push (but didn't care
> > because they didn't look at the working directory).
> 
> I wonder if you can use the tests 3/4 touches as the test for your "keep
> existing setup" configuration variable, pretending that they are old
> timer's repositories?

Yes, they do break with 4/4 applied without 3/4 (that was how I found them, but "git rebase -i" let me pretend I had the proper foresight. ;) ). We can keep 3/4 back until the switch from "warn" to "yes", if that's what you are suggesting.

-Peff