Re: [RFC PATCH 0/4] deny push to current branch of non-bare repo

From: Junio C Hamano <gitster@pobox.com>
Date: Nov 8, 2008, 20:49 UTC
Message-ID: <7vwsfeaqpa.fsf@gitster.siamese.dyndns.org>
In-Reply-To: <20081108142756.GC17100@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Yes, they do break with 4/4 applied without 3/4 (that was how I found
> them, but "git rebase -i" let me pretend I had the proper foresight. ;)
> ). We can keep 3/4 back until the switch from "warn" to "yes", if that's
> what you are suggesting.

I meant to suggest that change contained in 3/4 can instead be "set the configuration to allow such a dangerous push upfront, and make sure the pushes the current tests perform actually are still allowed", _if_ you are changing the default to forbid.

I think the default should be to warn for two release cycles during which we will give deprecation notice, and then switch the default to forbid (and we do not touch "git init/git clone" at all --- changing the default to forbid in newly created repositories earlier than existing repositories would be changing the behaviour of the command between old and new repositories, which is madness). If we are going this route, I think we can modify the tests 3/4 touches to set the configuration to allow such a push and make sure that such a push is still allowed.