Re: git bisect view's use of DISPLAY environment variable in Cygwin
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Oct 29, 2008, 00:46 UTC
- Message-ID
- <alpine.DEB.1.00.0810290144450.22125@pacific.mpi-cbg.de.mpi-cbg.de>
- In-Reply-To
- <83ej20cndw.fsf@kalahari.s2.org>
Hi,
On Wed, 29 Oct 2008, Hannu Koivisto wrote:
Show 18 quoted lines
> Hannu Koivisto <azure@iki.fi> writes: > > > "Christian Couder" <christian.couder@gmail.com> writes: > > > >> On Tue, Oct 28, 2008 at 6:51 PM, Hannu Koivisto <azure@iki.fi> wrote: > >>> "Christian Couder" <christian.couder@gmail.com> writes: > > > >> We need at least a way to detect we are under Cygwin, because we > >> won't change the current behavior for all platforms. Is checking for > >> the CYGWIN environment variable enough? > > > > No, because it may not be set. I would probably do it at compile time > > using __CYGWIN__ definition. I don't know what's the status > > Argh, I didn't realize git-bisect is a shell script. For detecting > Cygwin in shell scripts I have tested if `uname` matches CYGWIN*. For > detecting Windows I have tested if PROCESSOR_ARCHITECTURE is set. > There may well be better ways.
I submitted a patch a while ago, saying
bisect view: call gitk if Cygwin's SESSIONNAME variable is set
See http://repo.or.cz/w/git/dscho.git?a=commitdiff;h=a2637a3a003646c69ab5a6b85f0ee1bfac15e0b0
Ciao, Dscho