Re: git bisect view's use of DISPLAY environment variable in Cygwin

From: Hannu Koivisto <azure@iki.fi>
Date: Oct 28, 2008, 22:37 UTC
Message-ID: <83iqrccpmk.fsf@kalahari.s2.org>
In-Reply-To: <c07716ae0810281213k432d82d8i468f54ae03146b88@mail.gmail.com>

"Christian Couder" <christian.couder@gmail.com> writes:

> On Tue, Oct 28, 2008 at 6:51 PM, Hannu Koivisto <azure@iki.fi> wrote:
>> "Christian Couder" <christian.couder@gmail.com> writes:

> We need at least a way to detect we are under Cygwin, because we won't
> change the current behavior for all platforms.
> Is checking for the CYGWIN environment variable enough?

No, because it may not be set. I would probably do it at compile time using __CYGWIN__ definition. I don't know what's the status of merging MSysGit with "official" git but I suppose that when that happens, __MING32__ and/or _WIN32 or something would need to be considered as well.

Show 6 quoted lines

>>> You can use "git bisect view log" to use "git log" even if DISPLAY is set.
>>
>> I'd rather not use undocumented functionality ;)
>
> In this case you can use any "git log" option after "git bisect view"
> (for example: git bisect view -p).

I was implying that "log" after "git bisect view" is not documented by git-bisect(1). "log" is not a "git log" option.

-- 
Hannu